containerd / go-runc

runc bindings for Go
Apache License 2.0
161 stars 71 forks source link

Add `runc.Features(ctx)` to wrap `runc features` #97

Closed AkihiroSuda closed 1 year ago

AkihiroSuda commented 1 year ago

See https://github.com/opencontainers/runtime-spec/blob/v1.1.0-rc.2/features.md

Availability:

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 55.55% and project coverage change: +0.70 :tada:

Comparison is base (f5d58d0) 20.69% compared to head (d20f83b) 21.40%.

:exclamation: Current head d20f83b differs from pull request most recent head 6d29289. Consider uploading reports for the commit 6d29289 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ========================================== + Coverage 20.69% 21.40% +0.70% ========================================== Files 7 7 Lines 715 724 +9 ========================================== + Hits 148 155 +7 - Misses 527 528 +1 - Partials 40 41 +1 ``` | [Impacted Files](https://app.codecov.io/gh/containerd/go-runc/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [runc.go](https://app.codecov.io/gh/containerd/go-runc/pull/97?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cnVuYy5nbw==) | `21.78% <55.55%> (+0.76%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/containerd/go-runc/pull/97/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

AkihiroSuda commented 1 year ago

Can we release go-runc v1.1.0 after merging this?

fuweid commented 1 year ago

Can we release go-runc v1.1.0 after merging this?

SGTM