search

containerd / imgcrypt

OCI Image Encryption Package
Apache License 2.0
364 stars 47 forks source link

Update to ocicrypt 1.1.6 and add support for zstd type of compressed layers #96

Closed stefanberger closed 2 years ago

stefanberger commented 2 years ago

Update to ocicrypt 1.1.6 and add support for zstd type of compressed layers

k-gostev commented 2 years ago

@stefanberger Thanks a lot for your fast reaction, I really appreciate it! I did not test it but I would guess that the zstd media type checks should also be added in the decrypt functions as well.

stefanberger commented 2 years ago

I did not test it but I would guess that the zstd media type checks should also be added in the decrypt functions as well.

Added that now. Thanks.

stefanberger commented 2 years ago

Thanks for providing the steps. After another fix I can now encrypt end decrypt with zstd-compressed images.

stefanberger commented 2 years ago

It works for me, if it works for you @k-gostev as well , let me know and I'll merge it.

k-gostev commented 2 years ago

Works for me as well. Thank you! LGTM

k-gostev commented 2 years ago

BTW could you tell me what are your plans about the next release that will include this fix? When could be expected?

stefanberger commented 2 years ago

I can tag in the next few days.

stefanberger commented 2 years ago

@k-gostev I tagged v1.1.7 now.