recursive read-only (RRO) mount: support the Docker v25 form

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...

Apache License 2.0

8.18k stars 610 forks source link

recursive read-only (RRO) mount: support the Docker v25 form #2651

Open AkihiroSuda opened 1 year ago

AkihiroSuda commented 1 year ago

https://github.com/containerd/nerdctl/blob/4299debf881b375226fdf2fbb2a1f818f1d456f1/README.md?plain=1#L211-L215

Docker v25 attempts to apply RRO by default for read-only mounts with runc >= v1.1, kernel >= v5.12. The behavior is customizable with bind-recursive option for --mount (not for -v).

See:

https://github.com/docker/cli/pull/4316
https://github.com/docker/cli/pull/4606
https://github.com/docker/cli/pull/4671

AkihiroSuda commented 1 year ago

Depends on:

https://github.com/containerd/nerdctl/issues/1390

thaJeztah commented 12 months ago

Hope I didn't make life hard on you, removing the boolean format ❤️ (I was looking at it again, and thought "now" is the moment to still change it; and it's easier to add back later, than to ship it and remove later).