image history issues - Githubissues

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...

Apache License 2.0

7.64k stars 565 forks source link

image history issues #3019

Open apostasie opened 1 month ago

apostasie commented 1 month ago

Description

This ticket is meant to list all current issues with nerdctl image history when compared with docker image history.

1. [ ] fails if multiple tags point to the same image
- These are fundamentally the same image, with different tags.
- Resolution here ties partly into the overall issue of image IDs (see #3011), and partly into the way we lookup images (which is currently being reworked in #3017).
1. [ ] outputs spurious "Snapshot" property
- We can just remove this - or leave it if it serves a purpose.
1. [x] does not has "CreatedAt"
- Easy to do, as we already have the info (used for CreatedSince)
1. [x] size formatting leaves to be desired:
  - spurious space between number and unit "XXX B"
  - does not strip irrelevant digits (eg: 0.0 B)
- Responsible package is in containerd (progress/humaans.go), which actually uses docker/go-units under the hood.
- We are using it a few other places.
- We could just drop the intermediary dependency and use go-units directly for better display.
1. [ ] does not list ID
  - This one also ties into #3011 and #3017, and might be more involved to get done.
1. [x] fails when using "format" and "quiet" together
1. [x] does not implement the "human" flag - and overall doesn't display local time
1. [x] "Snapshot" takes a lot of space with the table display, and should be truncated unless --no-trunc or --quiet

Steps to reproduce the issue

For 1:

nerdctl pull debian
nerdctl tag debian testtag
nerdctl image history fac2c0fd33e8

> FATA[0000] 1 errors:
multiple IDs found with provided prefix: fac2c0fd33e8

For 2:

nerdctl image history debian | jq .Snapshot

For 3:

nerdctl image history debian | jq .CreatedAt

For 4:

nerdctl image history debian | jq .Size

For 5:

nerdctl image history debian | jq .ID

For 6:

nerdctl image history --format json --quiet debian

Describe the results you received and expected

Expect to behave like docker.

I will send a PR that fixes the easy / non-controversial ones. Let me know what you think about the other ones.

Thanks.

What version of nerdctl are you using?

1.7.6

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response

apostasie commented 1 month ago

Some of the issues fixed by #3020