containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...
Apache License 2.0
7.98k stars 594 forks source link

MAINTAINERS: promote Jin Dong (djdongjin) from a REVIEWER to a COMMITTER #3065

Closed AkihiroSuda closed 3 months ago

AkihiroSuda commented 3 months ago

@djdongjin has been a reviewer since Dec 2022 (https://github.com/containerd/nerdctl/pull/1649), and he has been very actively contributing to the project: https://github.com/containerd/nerdctl/pulls?q=author%3Adjdongjin+

So I'd like to promote @djdongjin to a committer.

Needs explicit LGTM from @djdongjin and 2/3 of the nerdctl Committers ( $ceil \left( 4 \times \frac{2}{3} \right) = 3$ ), according to https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the existing maintainers are given seven days to discuss the candidate, raise objections and show their support. Formal voting takes place on a pull request that adds the contributor to the MAINTAINERS file. Candidates must be approved by 2/3 of the current committers by adding their approval or LGTM to the pull request. The reviewer role has the same process but only requires 1/3 of current committers.

If a candidate is approved, they will be invited to add their own LGTM or approval to the pull request to acknowledge their agreement. A committer will verify the numbers of votes that have been received and the allotted seven days have passed, then merge the pull request and invite the contributor to the organization.

For non-core sub-projects, only committers of the repository that the candidate is proposed for are given votes.

I'd also like to get a few LGTMs from the Core Committers too. (not necessary)

This PR will remain open for 7 days.

ktock commented 3 months ago

LGTM. Welcome!

fahedouch commented 3 months ago

LGTM. Welcome!

djdongjin commented 3 months ago

LGTM. Thanks everyone! 🙏

AkihiroSuda commented 3 months ago

Welcome @djdongjin 🎉