Bump compose-go to v2 - Githubissues

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...

Apache License 2.0

7.62k stars 565 forks source link

Bump compose-go to v2 #3117

Closed apostasie closed 1 week ago

apostasie commented 1 week ago

This is not too bad. Basic functionality is here.

TBD

[x] .env files are bust
[x] Profiles are bust

apostasie commented 1 week ago

@AkihiroSuda

Feel like this one could go in or do we need some form of soak time? CI is green but our test coverage might be so-so.

Appreciate this is a "big" change (not many lines of code / not complex, but certainly impactful).

IMHO we should go for it and not stay behind longer (we can fix bugs as they come) - it will obviously only get worse the more we wait.

apostasie commented 1 week ago

@AkihiroSuda fixed the bizarro change in compose wrt host/ip. At least we do now honor the fact it is an array. Still not completely sure why / what is expected to happen here.