search

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...
Apache License 2.0
7.62k stars 565 forks source link

[release/1.7 backport] Add --pull option to build command #3121

Closed sondavidb closed 1 week ago

sondavidb commented 1 week ago

Backport of #3074. Also took some helper functions for pkg/testutil/testutil.go from https://github.com/containerd/nerdctl/commit/f853ab8542dfd85a8a53c435ebf39d1d1b10cd85.

Per https://github.com/containernetworking/plugins/issues/1038, the binaries were modified as of the last commit so this change also brings in the new shasums so that CI runs properly.

Mainline also requires Golang 1.22 so cherry-picked https://github.com/containerd/nerdctl/commit/4e615922c484817898c81f4c70cbf6abeb8a89f9.

Feel free to close if we are not taking features into release/1.7.

AkihiroSuda commented 1 week ago

I'm not sure we should backport new features to v1.7, but still negotiable if this is urgent for Finch.

sondavidb commented 1 week ago

still negotiable if this is urgent for Finch.

It's not urgent, and we should prepare for 2.0 upgrade anyway in the future. Closing for now, thanks for your input!