search

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...
Apache License 2.0
7.98k stars 594 forks source link

Bug bash for 2.0? #3363

Open apostasie opened 1 month ago

apostasie commented 1 month ago

What is the problem you're trying to solve

Hey folks,

Really pumped-up about 2.0 getting closer :-) - and I thought I would suggest this: What about a bug bash and shake-up of the bug tracker?

If you good people are open to the idea and have time for that, what about the following for a starter:

Then on top of that, we could start tackling bug reports from the top:

Tagging @AkihiroSuda @ktock @fahedouch @Zheaoli @djdongjin @yankay @sondavidb

Describe the solution you'd like

na

Additional context

No response

sondavidb commented 1 month ago

Thanks for taking the initiative on this! I'll comb through and see if there's anything I can help confirm/fix.

I have one open issue myself (#3156) but it's more of a feature request than a bug, and honestly I can't recall what the ask was when I made this issue. Feel free to close it if we think current tests are sufficient.

FWIW, I work off a Windows machine so feel free to ping me if you want me to test anything.

apostasie commented 1 month ago

FWIW, I work off a Windows machine so feel free to ping me if you want me to test anything.

@sondavidb

That's nice. I still need to setup myself with a windows VM but this has taken a backseat in the todo list :(

I guess on my windows radar, these would be interesting to look into:

This one is pending next containerd rc:

And there is a handful of issues here, where any progress would be lovely:

TinaMor commented 3 weeks ago

@apostasie

I guess on my windows radar, these would be interesting to look into:

This PR Allow for binding a named pipe on Windows #2661 addresses #759. Related PRs: #2160 and #924

This one is pending next containerd rc:

Published the PR. Awaiting reviews

And there is a handful of issues here, where any progress would be lovely:

cc. @lucillex

apostasie commented 3 weeks ago

Thanks a lot @TinaMor

apostasie commented 3 weeks ago

Update:

Looking good!

We have a somewhat "large", long lasting problem collected in #3425. Fixing the underlying cause there would likely significantly increase reliability on many operations (chiefly commit and build), and would certainly close half a dozen confirmed issues.

Help is required on this one, as it is quite tricky.

apostasie commented 1 week ago

Windows folks: recent changes in code / or (more likely) tests did break the windows CI significantly (now failing very often) a few weeks ago.

Details are here: #3437

The regression may have been introduced by this PR: #3304 - although this is unconfirmed.

It would be really nice to have windows savvy peeps looking into this :-)

Tagging the windowsians I know of: @sondavidb @TinaMor @jsturtevant

apostasie commented 6 days ago

Windows folks: recent changes in code / or (more likely) tests did break the windows CI significantly (now failing very often) a few weeks ago.

FWIW, I tried adding a sleep inside the test before we call logs (5 seconds), just in case things would be slow / racy - it still failed.