search

containerd / nerdctl

contaiNERD CTL - Docker-compatible CLI for containerd, with support for Compose, Rootless, eStargz, OCIcrypt, IPFS, ...
Apache License 2.0
7.98k stars 594 forks source link

Rename `containerd-rootless-setuptool.sh` #3449

Closed abitrolly closed 1 week ago

abitrolly commented 1 week ago

containerd-rootless-setuptool.sh is now containerd-rootless-systemd.sh

To clarify what this tool does.

Closes #66.

fahedouch commented 1 week ago

Hi @abitrolly, I don't think is a good idea to suffix the script name by systemd as it just uses systemd to setup multiple (buildkit, containerd..) tool. We may add some notes to doc.

abitrolly commented 1 week ago

@fahedouch then it is probably containerd prefix that should be removed. Something like setuptool-rootless-systemd.sh.

AkihiroSuda commented 1 week ago

For the sake of compatibility the script name shouldn’t be changed unless there is an extremely convincing reason.

Also, the script may potentially support non-systemd inits (if somebody works on it).

So I’m rejecting this PR.