containerd / nri

Node Resource Interface
Apache License 2.0
257 stars 65 forks source link

device-injector: remove unreachable code. #115

Closed CormickKneey closed 1 month ago

kad commented 1 month ago

for code changes, no questions, but for go.mod changes, I think it should be not part of this PR.

CormickKneey commented 1 month ago

The core changes, IOW the removal of unreachable code is fine. But there are also a few seemingly unrelated dependency changes and an incorrect-looking update to a comment-directive tossed in there as well. I wonder if the deps changes are unintentional and the directive change, too....

well, it's unintentional change and i revert it...