containerd / nri

Node Resource Interface
Apache License 2.0
257 stars 65 forks source link

fixes: sort final adjusted mount slice. #29

Closed klihub closed 1 year ago

klihub commented 1 year ago

If mounts get adjusted, sort the final mount slice to make sure that any potential subdirectories are mounted only after their parents. Otherwise a parent mount could shadow/mask the content of a previously mounted subdirectory.

codecov-commenter commented 1 year ago

Codecov Report

Base: 63.39% // Head: 63.83% // Increases project coverage by +0.44% :tada:

Coverage data is based on head (2256f8c) compared to base (f6a7cac). Patch coverage: 86.36% of modified lines in pull request are covered.

:exclamation: Current head 2256f8c differs from pull request most recent head 7b08072. Consider uploading reports for the commit 7b08072 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #29 +/- ## ========================================== + Coverage 63.39% 63.83% +0.44% ========================================== Files 9 9 Lines 1781 1800 +19 ========================================== + Hits 1129 1149 +20 + Misses 501 500 -1 Partials 151 151 ``` | [Impacted Files](https://codecov.io/gh/containerd/nri/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [pkg/runtime-tools/generate/generate.go](https://codecov.io/gh/containerd/nri/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL3J1bnRpbWUtdG9vbHMvZ2VuZXJhdGUvZ2VuZXJhdGUuZ28=) | `34.45% <86.36%> (+6.59%)` | :arrow_up: | | [pkg/net/multiplex/mux.go](https://codecov.io/gh/containerd/nri/pull/29?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL25ldC9tdWx0aXBsZXgvbXV4Lmdv) | `67.52% <0.00%> (-0.52%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

fuweid commented 1 year ago

@klihub is it ok to create v0.3.0 tag after this merged?

klihub commented 1 year ago

@fuweid Yes, let's tag it. I have no other PRs ATM in the pipeline.

fuweid commented 1 year ago

@fuweid Yes, let's tag it. I have no other PRs ATM in the pipeline.

nice! I will create tag in two days.