Closed swgriffith closed 1 year ago
Patch coverage has no change and project coverage change: +0.16
:tada:
Comparison is base (
2a8b655
) 63.83% compared to head (57cfa26
) 64.00%.:exclamation: Current head 57cfa26 differs from pull request most recent head c783fc7. Consider uploading reports for the commit c783fc7 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Maybe it would be more sense to point to top of the tree like https://github.com/containers/common/tree/main/pkg/hooks and https://github.com/containers/common/blob/main/pkg/hooks/docs/oci-hooks.5.md instead of some older commit id in podman repo?
Maybe it would be more sense to point to top of the tree like https://github.com/containers/common/tree/main/pkg/hooks and https://github.com/containers/common/blob/main/pkg/hooks/docs/oci-hooks.5.md instead of some older commit id in podman repo?
We deliberately chose to point to the exact version we use in the plugin. That is then a different story that we should really file another PR to update the plugin to use a recent version, and then (remember to) update the link in the same PR as well.
@klihub and @kad - It sounds like we're leaving it as is. Let me know if you need me to change the URLs.
I'm ok with @klihub opinion, so lgtm.
Resolves issue #33
Updates the links to podman documentation to reference the proper sha1 and adds additional details to help guide people in testing the hook-injector plugin, including relevant path details.