Closed eclipseo closed 1 year ago
Patch and project coverage have no change.
Comparison is base (
040229d
) 64.38% compared to head (5144aa9
) 64.38%. Report is 2 commits behind head on main.:exclamation: Current head 5144aa9 differs from pull request most recent head d708940. Consider uploading reports for the commit d708940 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Pls sign commits with real name and email. Cheers!
@eclipseo wave..
Ok fixed the import path and signed the commit.
Building /home/runner/work/nri/nri/src/github.com/containerd/nri/build/bin/logger...
go: downloading github.com/sirupsen/logrus v1.9.0
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading github.com/containerd/ttrpc v1.1.1-0.20220420014843-944ef4a40df3
go: downloading github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb
go: downloading google.golang.org/protobuf v1.28.1
go: downloading k8s.io/cri-api v0.25.3
go: downloading golang.org/x/sys v0.1.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading google.golang.org/genproto v0.0.0-20220502173005-c8bf987b8c21
go: downloading google.golang.org/grpc v1.47.0
go: downloading golang.org/x/net v0.1.0
go: downloading github.com/golang/protobuf v1.5.2
go: downloading golang.org/x/text v0.4.0
go: updates to go.mod needed; to update it:
go mod tidy
make: *** [Makefile:93: /home/runner/work/nri/nri/src/github.com/containerd/nri/build/bin/logger] Error 1
Error: Process completed with exit code 2.
I did do a go mod tidy
, and doing another one does nothing.
I gave it a quick go to carry the change in https://github.com/containerd/nri/pull/55
changes compared to this PR;
rebase (we merged the "remove containerd dependency" removed changes from other plugin go mods (keeping the PR focussed on just this change) updated to containers/common v0.56.0 (which uses runtime spec v1.1.0 instead of -rc.3)
Replaced by #55.
pkg/hooks was moved from github.com/containers/podman/v4 to github.com/containers/common and it's to much time consuming to keep packaging github.com/containers/podman/v3.