remove containerd as dependency

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.11% :warning:

Comparison is base (976af01) 64.61% compared to head (3da0047) 64.50%.

:exclamation: Current head 3da0047 differs from pull request most recent head da8a7e5. Consider uploading reports for the commit da8a7e5 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== - Coverage 64.61% 64.50% -0.11% ========================================== Files 9 9 Lines 1834 1834 ========================================== - Hits 1185 1183 -2 - Misses 498 500 +2 Partials 151 151 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/containerd/nri/pull/51/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[thaJeztah]

This looks odd; running go mod tidy does not produce a diff for me, but I'm wondering if it's either trying to use the code not as a separate module. Current run works, but previous one showed this;

Error: /home/runner/go/pkg/mod/github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3/client.go:30:2: missing go.sum entry for module providing package github.com/sirupsen/logrus (imported by github.com/containerd/nri/plugins/template); to add:
    go get github.com/containerd/nri/plugins/template
Error: /home/runner/go/pkg/mod/github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3/unixcreds_linux.go:27:2: missing go.sum entry for module providing package golang.org/x/sys/unix (imported by github.com/containerd/ttrpc); to add:
    go get github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3
make: *** [Makefile:113: /home/runner/work/nri/nri/build/bin/template] Error 1
Error: Process completed with exit code 2.

Or... something very fishy (full output below, or here: https://pipelinesghubeus24.actions.githubusercontent.com/nAcqJVvhK0M1GSKfg9ZtIaPG34KOIcpFPpt533m0kSjW9jw8oI/_apis/pipelines/1/runs/229/signedlogcontent/2?urlExpires=2023-09-13T08%3A44%3A19.0508573Z&urlSigningMethod=HMACV1&urlSignature=APJ8a64QufPmeEyDpd6xk4WRCZm0HNjTtEv6SThju%2BM%3D);

This project no longer uses vendoring, but the logs output shows multiple vendored packages? Is state not cleaned between runs or something odd?

2023-09-13T08:09:13.5856109Z crypto/dsa
2023-09-13T08:09:13.6241118Z encoding/hex
2023-09-13T08:09:13.6566336Z encoding/pem
2023-09-13T08:09:13.6672236Z crypto/x509/pkix
2023-09-13T08:09:13.7013051Z vendor/golang.org/x/crypto/chacha20
2023-09-13T08:09:13.7225338Z crypto/x509
2023-09-13T08:09:13.7730050Z vendor/golang.org/x/crypto/internal/poly1305
2023-09-13T08:09:13.8461302Z vendor/golang.org/x/sys/cpu
2023-09-13T08:09:13.8994349Z vendor/golang.org/x/crypto/chacha20poly1305
2023-09-13T08:09:14.0305663Z vendor/golang.org/x/crypto/hkdf
2023-09-13T08:09:14.0609146Z vendor/golang.org/x/text/transform
2023-09-13T08:09:14.1358728Z vendor/golang.org/x/text/unicode/bidi
2023-09-13T08:09:14.4065205Z vendor/golang.org/x/text/secure/bidirule
2023-09-13T08:09:14.4425583Z vendor/golang.org/x/text/unicode/norm
2023-09-13T08:09:14.4813185Z crypto/tls
2023-09-13T08:09:14.9576855Z vendor/golang.org/x/net/idna
2023-09-13T08:09:15.3306442Z net/textproto
2023-09-13T08:09:15.4941144Z vendor/golang.org/x/net/http/httpguts
2023-09-13T08:09:15.5702534Z vendor/golang.org/x/net/http/httpproxy
2023-09-13T08:09:15.6687744Z vendor/golang.org/x/net/http2/hpack
2023-09-13T08:09:15.8020145Z mime
2023-09-13T08:09:15.9956854Z mime/quotedprintable

```console 2023-09-13T08:08:17.6783688Z make 2023-09-13T08:08:17.6846575Z shell: /usr/bin/bash -e {0} 2023-09-13T08:08:17.6846840Z env: 2023-09-13T08:08:17.6847123Z CODEQL_ACTION_FEATURE_MULTI_LANGUAGE: false 2023-09-13T08:08:17.6847430Z CODEQL_ACTION_FEATURE_SANDWICH: false 2023-09-13T08:08:17.6848519Z CODEQL_ACTION_FEATURE_SARIF_COMBINE: true 2023-09-13T08:08:17.6848903Z CODEQL_ACTION_FEATURE_WILL_UPLOAD: true 2023-09-13T08:08:17.6849205Z CODEQL_ACTION_VERSION: 2.21.5 2023-09-13T08:08:17.6849539Z JOB_RUN_UUID: d1700d41-9514-4fce-96ff-63847b1a18cc 2023-09-13T08:08:17.6849942Z CODEQL_ACTION_ANALYSIS_KEY: .github/workflows/codeql.yml:CodeQL-Build 2023-09-13T08:08:17.6850657Z CODEQL_WORKFLOW_STARTED_AT: 2023-09-13T08:08:06.829Z 2023-09-13T08:08:17.6850967Z CODEQL_RAM: 5907 2023-09-13T08:08:17.6851229Z CODEQL_THREADS: 2 2023-09-13T08:08:17.6851571Z CODEQL_EXTRACTOR_KOTLIN_OVERRIDE_MAXIMUM_VERSION_LIMIT: 1.9.20 2023-09-13T08:08:17.6852041Z CODEQL_EXTRACTOR_PYTHON_DISABLE_LIBRARY_EXTRACTION: true 2023-09-13T08:08:17.6852471Z CODEQL_TRACER_LOG: /home/runner/work/_temp/codeql_databases/log/build-tracer.log 2023-09-13T08:08:17.6853204Z CODEQL_TRACER_DIAGNOSTICS_DIR: /home/runner/work/_temp/codeql_databases/diagnostic/tracer 2023-09-13T08:08:17.6853590Z CODEQL_TRACER_LANGUAGES: go 2023-09-13T08:08:17.6854422Z SEMMLE_PRELOAD_libtrace: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/${LIB}_${PLATFORM}_trace.so 2023-09-13T08:08:17.6855012Z SEMMLE_PRELOAD_libtrace32: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/lib32trace.so 2023-09-13T08:08:17.6855554Z SEMMLE_PRELOAD_libtrace64: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/lib64trace.so 2023-09-13T08:08:17.6855920Z CODEQL_PLATFORM: linux64 2023-09-13T08:08:17.6856214Z CODEQL_DIST: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql 2023-09-13T08:08:17.6856831Z CODEQL_SCRATCH_DIR: /home/runner/work/_temp/codeql_databases/working 2023-09-13T08:08:17.6857188Z CODEQL_PLATFORM_DLL_EXTENSION: .so 2023-09-13T08:08:17.6857544Z CODEQL_JAVA_HOME: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/java 2023-09-13T08:08:17.6858037Z CODEQL_EXTRACTOR_GO_ROOT: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/go 2023-09-13T08:08:17.6858633Z CODEQL_EXTRACTOR_GO_WIP_DATABASE: /home/runner/work/_temp/codeql_databases/go 2023-09-13T08:08:17.6859276Z CODEQL_EXTRACTOR_GO_DIAGNOSTIC_DIR: /home/runner/work/_temp/codeql_databases/go/diagnostic/extractors/go 2023-09-13T08:08:17.6859867Z CODEQL_EXTRACTOR_GO_LOG_DIR: /home/runner/work/_temp/codeql_databases/go/log 2023-09-13T08:08:17.6860284Z CODEQL_EXTRACTOR_GO_SCRATCH_DIR: /home/runner/work/_temp/codeql_databases/go/working 2023-09-13T08:08:17.6861109Z CODEQL_EXTRACTOR_GO_TRAP_DIR: /home/runner/work/_temp/codeql_databases/go/trap/go 2023-09-13T08:08:17.6861701Z CODEQL_EXTRACTOR_GO_SOURCE_ARCHIVE_DIR: /home/runner/work/_temp/codeql_databases/go/src 2023-09-13T08:08:17.6862285Z CODEQL_EXTRACTOR_GO_THREADS: 2 2023-09-13T08:08:17.6862764Z CODEQL_EXTRACTOR_GO_RAM: 5907 2023-09-13T08:08:17.6863165Z LD_PRELOAD: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/${LIB}_${PLATFORM}_trace.so 2023-09-13T08:08:17.6863637Z CODEQL_RUNNER: /opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/tools/linux64/runner 2023-09-13T08:08:17.6864140Z ##[endgroup] 2023-09-13T08:08:17.7738982Z go: downloading github.com/containerd/ttrpc v1.1.1-0.20220420014843-944ef4a40df3 2023-09-13T08:08:17.7795617Z go: downloading golang.org/x/sys v0.7.0 2023-09-13T08:08:18.1652009Z go: downloading github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb 2023-09-13T08:08:18.1722588Z go: downloading google.golang.org/protobuf v1.28.1 2023-09-13T08:08:18.4209974Z go: downloading k8s.io/cri-api v0.25.3 2023-09-13T08:08:18.4306826Z go: downloading github.com/sirupsen/logrus v1.9.3 2023-09-13T08:08:18.5754752Z go: downloading github.com/moby/sys/mountinfo v0.6.2 2023-09-13T08:08:18.6048763Z go: downloading github.com/opencontainers/runtime-tools v0.0.0-20221026201742-946c877fa809 2023-09-13T08:08:18.6906583Z go: downloading google.golang.org/genproto v0.0.0-20220502173005-c8bf987b8c21 2023-09-13T08:08:19.0552911Z go: downloading google.golang.org/grpc v1.47.0 2023-09-13T08:08:19.6863290Z go: downloading github.com/gogo/protobuf v1.3.2 2023-09-13T08:08:20.5251737Z go: downloading github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635 2023-09-13T08:08:20.5851849Z go: downloading golang.org/x/net v0.1.0 2023-09-13T08:08:20.8879316Z go: downloading github.com/golang/protobuf v1.5.2 2023-09-13T08:08:21.1971578Z go: downloading golang.org/x/text v0.4.0 2023-09-13T08:08:53.4607636Z internal/goarch 2023-09-13T08:08:53.6361982Z internal/unsafeheader 2023-09-13T08:08:53.7439541Z internal/abi 2023-09-13T08:08:53.7448814Z internal/cpu 2023-09-13T08:08:53.8034734Z internal/coverage/rtcov 2023-09-13T08:08:53.8169241Z internal/goexperiment 2023-09-13T08:08:53.8238891Z internal/bytealg 2023-09-13T08:08:53.8314904Z internal/goos 2023-09-13T08:08:53.8489991Z runtime/internal/atomic 2023-09-13T08:08:53.9016774Z runtime/internal/math 2023-09-13T08:08:53.9153014Z runtime/internal/sys 2023-09-13T08:08:53.9235090Z runtime/internal/syscall 2023-09-13T08:08:53.9382552Z internal/race 2023-09-13T08:08:53.9506970Z sync/atomic 2023-09-13T08:08:54.0330377Z runtime 2023-09-13T08:08:54.0463011Z unicode 2023-09-13T08:08:54.3000972Z unicode/utf8 2023-09-13T08:08:54.3412040Z internal/itoa 2023-09-13T08:08:54.3535746Z encoding 2023-09-13T08:08:54.3656719Z math/bits 2023-09-13T08:08:54.4176539Z math 2023-09-13T08:08:54.7286334Z unicode/utf16 2023-09-13T08:08:54.7588792Z google.golang.org/protobuf/internal/flags 2023-09-13T08:08:54.7675663Z google.golang.org/protobuf/internal/set 2023-09-13T08:08:54.7824445Z internal/nettrace 2023-09-13T08:08:54.7950317Z container/list 2023-09-13T08:08:54.8333255Z crypto/internal/alias 2023-09-13T08:08:54.8441746Z crypto/subtle 2023-09-13T08:08:54.8813397Z crypto/internal/boring/sig 2023-09-13T08:08:54.9131602Z vendor/golang.org/x/crypto/cryptobyte/asn1 2023-09-13T08:08:54.9295150Z vendor/golang.org/x/crypto/internal/alias 2023-09-13T08:08:54.9454399Z google.golang.org/grpc/attributes 2023-09-13T08:08:54.9748755Z google.golang.org/grpc/serviceconfig 2023-09-13T08:08:57.7588567Z internal/reflectlite 2023-09-13T08:08:57.7588875Z sync 2023-09-13T08:08:57.8836323Z internal/testlog 2023-09-13T08:08:57.9080804Z internal/godebug 2023-09-13T08:08:57.9657410Z google.golang.org/protobuf/internal/pragma 2023-09-13T08:08:57.9882807Z math/rand 2023-09-13T08:08:58.1342899Z internal/singleflight 2023-09-13T08:08:58.1697212Z internal/intern 2023-09-13T08:08:58.2221830Z runtime/cgo 2023-09-13T08:08:58.2373451Z errors 2023-09-13T08:08:58.2735659Z io 2023-09-13T08:08:58.3798784Z bytes 2023-09-13T08:08:58.5387016Z internal/oserror 2023-09-13T08:08:58.5638569Z syscall 2023-09-13T08:08:59.1436187Z strconv 2023-09-13T08:08:59.2232529Z time 2023-09-13T08:08:59.4692861Z reflect 2023-09-13T08:08:59.7547763Z context 2023-09-13T08:08:59.8218723Z sort 2023-09-13T08:08:59.9509341Z internal/syscall/unix 2023-09-13T08:08:59.9827374Z internal/poll 2023-09-13T08:09:00.2485326Z internal/safefilepath 2023-09-13T08:09:00.2621800Z internal/syscall/execenv 2023-09-13T08:09:00.2831655Z path 2023-09-13T08:09:00.3572352Z io/fs 2023-09-13T08:09:00.4958005Z os 2023-09-13T08:09:00.8387634Z strings 2023-09-13T08:09:01.0777487Z path/filepath 2023-09-13T08:09:01.0851984Z encoding/binary 2023-09-13T08:09:01.2025992Z internal/fmtsort 2023-09-13T08:09:01.2668622Z encoding/base64 2023-09-13T08:09:01.2861917Z fmt 2023-09-13T08:09:01.3357328Z os/exec 2023-09-13T08:09:01.5141754Z bufio 2023-09-13T08:09:01.6840385Z golang.org/x/sys/unix 2023-09-13T08:09:01.7646589Z encoding/json 2023-09-13T08:09:02.3659290Z github.com/containerd/nri/types/v1 2023-09-13T08:09:02.3845180Z github.com/opencontainers/runtime-spec/specs-go 2023-09-13T08:09:02.4241919Z github.com/containerd/nri 2023-09-13T08:09:02.4706254Z log 2023-09-13T08:09:02.5423799Z hash 2023-09-13T08:09:02.5580539Z hash/fnv 2023-09-13T08:09:02.6213062Z google.golang.org/protobuf/internal/detrand 2023-09-13T08:09:02.6445206Z google.golang.org/protobuf/internal/errors 2023-09-13T08:09:02.6820572Z google.golang.org/protobuf/encoding/protowire 2023-09-13T08:09:02.7367414Z google.golang.org/protobuf/reflect/protoreflect 2023-09-13T08:09:03.0425199Z google.golang.org/protobuf/internal/descfmt 2023-09-13T08:09:03.1446424Z google.golang.org/protobuf/internal/descopts 2023-09-13T08:09:03.1582982Z go/token 2023-09-13T08:09:03.2625339Z google.golang.org/protobuf/internal/strs 2023-09-13T08:09:03.3107783Z google.golang.org/protobuf/internal/encoding/text 2023-09-13T08:09:03.3754538Z github.com/sirupsen/logrus 2023-09-13T08:09:03.5018887Z google.golang.org/protobuf/internal/encoding/defval 2023-09-13T08:09:03.5489434Z google.golang.org/protobuf/internal/encoding/messageset 2023-09-13T08:09:03.6355402Z google.golang.org/protobuf/internal/genid 2023-09-13T08:09:03.6673379Z google.golang.org/protobuf/internal/order 2023-09-13T08:09:03.7109259Z google.golang.org/protobuf/reflect/protoregistry 2023-09-13T08:09:03.7200869Z google.golang.org/protobuf/runtime/protoiface 2023-09-13T08:09:03.7409189Z compress/flate 2023-09-13T08:09:03.9040998Z google.golang.org/protobuf/proto 2023-09-13T08:09:03.9608019Z hash/crc32 2023-09-13T08:09:04.0283086Z compress/gzip 2023-09-13T08:09:04.1311014Z io/ioutil 2023-09-13T08:09:04.1697874Z google.golang.org/protobuf/internal/version 2023-09-13T08:09:04.1838884Z google.golang.org/grpc/codes 2023-09-13T08:09:04.2053690Z google.golang.org/protobuf/internal/filedesc 2023-09-13T08:09:04.2062813Z google.golang.org/protobuf/encoding/prototext 2023-09-13T08:09:04.4105006Z vendor/golang.org/x/net/dns/dnsmessage 2023-09-13T08:09:04.8200769Z net/netip 2023-09-13T08:09:04.8931156Z google.golang.org/protobuf/internal/encoding/tag 2023-09-13T08:09:04.9519177Z google.golang.org/protobuf/internal/impl 2023-09-13T08:09:05.0799349Z net 2023-09-13T08:09:07.3716936Z google.golang.org/protobuf/internal/filetype 2023-09-13T08:09:07.5104479Z google.golang.org/protobuf/runtime/protoimpl 2023-09-13T08:09:07.5789481Z google.golang.org/protobuf/types/known/anypb 2023-09-13T08:09:07.6732810Z google.golang.org/genproto/googleapis/rpc/status 2023-09-13T08:09:07.7589530Z google.golang.org/protobuf/types/descriptorpb 2023-09-13T08:09:07.9040070Z github.com/golang/protobuf/ptypes/any 2023-09-13T08:09:07.9426922Z google.golang.org/protobuf/types/known/durationpb 2023-09-13T08:09:07.9889886Z github.com/golang/protobuf/ptypes/duration 2023-09-13T08:09:08.0182590Z google.golang.org/protobuf/types/known/timestamppb 2023-09-13T08:09:08.0728839Z github.com/golang/protobuf/ptypes/timestamp 2023-09-13T08:09:08.1086748Z google.golang.org/protobuf/reflect/protodesc 2023-09-13T08:09:08.1106099Z github.com/gogo/protobuf/proto 2023-09-13T08:09:08.5012253Z github.com/golang/protobuf/proto 2023-09-13T08:09:08.9909386Z github.com/golang/protobuf/ptypes 2023-09-13T08:09:09.0790153Z google.golang.org/grpc/internal/status 2023-09-13T08:09:09.1266921Z google.golang.org/grpc/status 2023-09-13T08:09:09.1649480Z github.com/containerd/ttrpc 2023-09-13T08:09:09.5946383Z github.com/gogo/protobuf/sortkeys 2023-09-13T08:09:09.6348226Z golang.org/x/net/internal/timeseries 2023-09-13T08:09:09.7197230Z html 2023-09-13T08:09:09.8571131Z net/url 2023-09-13T08:09:10.0536972Z text/template/parse 2023-09-13T08:09:10.5378710Z text/template 2023-09-13T08:09:10.6741719Z github.com/gogo/protobuf/protoc-gen-gogo/descriptor 2023-09-13T08:09:11.0553633Z html/template 2023-09-13T08:09:11.2754926Z github.com/gogo/protobuf/gogoproto 2023-09-13T08:09:11.3773298Z crypto 2023-09-13T08:09:11.4028854Z crypto/cipher 2023-09-13T08:09:11.5076950Z crypto/internal/boring 2023-09-13T08:09:11.5421220Z crypto/internal/randutil 2023-09-13T08:09:11.5505117Z math/big 2023-09-13T08:09:11.5590511Z crypto/aes 2023-09-13T08:09:11.6655409Z crypto/des 2023-09-13T08:09:11.7107696Z crypto/internal/edwards25519/field 2023-09-13T08:09:11.7995449Z crypto/internal/nistec/fiat 2023-09-13T08:09:12.4259931Z crypto/rand 2023-09-13T08:09:12.4749871Z embed 2023-09-13T08:09:12.5030431Z crypto/internal/bigmod 2023-09-13T08:09:12.5368055Z crypto/internal/nistec 2023-09-13T08:09:12.6137389Z crypto/internal/boring/bbig 2023-09-13T08:09:12.6327698Z crypto/sha512 2023-09-13T08:09:12.7145481Z encoding/asn1 2023-09-13T08:09:12.8739616Z crypto/ecdh 2023-09-13T08:09:12.9823210Z crypto/elliptic 2023-09-13T08:09:12.9850537Z vendor/golang.org/x/crypto/cryptobyte 2023-09-13T08:09:13.1652462Z crypto/internal/edwards25519 2023-09-13T08:09:13.1938921Z crypto/ecdsa 2023-09-13T08:09:13.3108472Z crypto/ed25519 2023-09-13T08:09:13.3855489Z crypto/hmac 2023-09-13T08:09:13.4044273Z crypto/md5 2023-09-13T08:09:13.4097835Z crypto/rc4 2023-09-13T08:09:13.4270801Z crypto/rsa 2023-09-13T08:09:13.4715995Z crypto/sha1 2023-09-13T08:09:13.5685208Z crypto/sha256 2023-09-13T08:09:13.5856109Z crypto/dsa 2023-09-13T08:09:13.6241118Z encoding/hex 2023-09-13T08:09:13.6566336Z encoding/pem 2023-09-13T08:09:13.6672236Z crypto/x509/pkix 2023-09-13T08:09:13.7013051Z vendor/golang.org/x/crypto/chacha20 2023-09-13T08:09:13.7225338Z crypto/x509 2023-09-13T08:09:13.7730050Z vendor/golang.org/x/crypto/internal/poly1305 2023-09-13T08:09:13.8461302Z vendor/golang.org/x/sys/cpu 2023-09-13T08:09:13.8994349Z vendor/golang.org/x/crypto/chacha20poly1305 2023-09-13T08:09:14.0305663Z vendor/golang.org/x/crypto/hkdf 2023-09-13T08:09:14.0609146Z vendor/golang.org/x/text/transform 2023-09-13T08:09:14.1358728Z vendor/golang.org/x/text/unicode/bidi 2023-09-13T08:09:14.4065205Z vendor/golang.org/x/text/secure/bidirule 2023-09-13T08:09:14.4425583Z vendor/golang.org/x/text/unicode/norm 2023-09-13T08:09:14.4813185Z crypto/tls 2023-09-13T08:09:14.9576855Z vendor/golang.org/x/net/idna 2023-09-13T08:09:15.3306442Z net/textproto 2023-09-13T08:09:15.4941144Z vendor/golang.org/x/net/http/httpguts 2023-09-13T08:09:15.5702534Z vendor/golang.org/x/net/http/httpproxy 2023-09-13T08:09:15.6687744Z vendor/golang.org/x/net/http2/hpack 2023-09-13T08:09:15.8020145Z mime 2023-09-13T08:09:15.9956854Z mime/quotedprintable 2023-09-13T08:09:16.0404044Z mime/multipart 2023-09-13T08:09:16.0642761Z net/http/httptrace 2023-09-13T08:09:16.1066477Z net/http/internal 2023-09-13T08:09:16.1575606Z net/http/internal/ascii 2023-09-13T08:09:16.1711480Z text/tabwriter 2023-09-13T08:09:16.1867334Z net/http 2023-09-13T08:09:16.2333461Z google.golang.org/grpc/backoff 2023-09-13T08:09:16.2446553Z google.golang.org/grpc/internal/grpclog 2023-09-13T08:09:16.2716390Z google.golang.org/grpc/grpclog 2023-09-13T08:09:16.3663411Z google.golang.org/grpc/connectivity 2023-09-13T08:09:16.3824653Z google.golang.org/grpc/internal/credentials 2023-09-13T08:09:16.4295464Z google.golang.org/grpc/credentials 2023-09-13T08:09:16.5094235Z google.golang.org/grpc/internal/channelz 2023-09-13T08:09:16.7409722Z google.golang.org/grpc/channelz 2023-09-13T08:09:16.7529142Z regexp/syntax 2023-09-13T08:09:17.1968004Z regexp 2023-09-13T08:09:17.5156242Z google.golang.org/protobuf/internal/encoding/json 2023-09-13T08:09:17.7074978Z google.golang.org/protobuf/encoding/protojson 2023-09-13T08:09:18.2625514Z github.com/golang/protobuf/jsonpb 2023-09-13T08:09:18.5665946Z google.golang.org/grpc/internal/pretty 2023-09-13T08:09:18.5886927Z google.golang.org/grpc/resolver 2023-09-13T08:09:18.6390278Z google.golang.org/grpc/internal 2023-09-13T08:09:18.6812588Z google.golang.org/grpc/metadata 2023-09-13T08:09:18.7357917Z google.golang.org/grpc/balancer 2023-09-13T08:09:18.7721451Z google.golang.org/grpc/balancer/base 2023-09-13T08:09:18.8391062Z google.golang.org/grpc/internal/grpcrand 2023-09-13T08:09:18.8900752Z google.golang.org/grpc/balancer/roundrobin 2023-09-13T08:09:18.9461341Z google.golang.org/grpc/credentials/insecure 2023-09-13T08:09:18.9959869Z google.golang.org/grpc/encoding 2023-09-13T08:09:19.0296749Z google.golang.org/grpc/encoding/proto 2023-09-13T08:09:19.0681798Z google.golang.org/grpc/internal/backoff 2023-09-13T08:09:19.0956002Z google.golang.org/grpc/internal/balancer/gracefulswitch 2023-09-13T08:09:19.1918343Z google.golang.org/grpc/internal/balancerload 2023-09-13T08:09:19.2038018Z google.golang.org/grpc/binarylog/grpc_binarylog_v1 2023-09-13T08:09:19.3273968Z google.golang.org/grpc/internal/grpcutil 2023-09-13T08:09:19.3656794Z google.golang.org/grpc/internal/binarylog 2023-09-13T08:09:19.5795737Z google.golang.org/grpc/internal/buffer 2023-09-13T08:09:19.5953135Z google.golang.org/grpc/internal/grpcsync 2023-09-13T08:09:19.6084247Z google.golang.org/grpc/internal/metadata 2023-09-13T08:09:19.6324004Z google.golang.org/grpc/internal/serviceconfig 2023-09-13T08:09:19.6599072Z google.golang.org/grpc/internal/resolver 2023-09-13T08:09:19.6889575Z google.golang.org/grpc/balancer/grpclb/state 2023-09-13T08:09:19.7021356Z google.golang.org/grpc/internal/envconfig 2023-09-13T08:09:19.7135296Z google.golang.org/grpc/internal/resolver/dns 2023-09-13T08:09:19.8065202Z google.golang.org/grpc/internal/resolver/passthrough 2023-09-13T08:09:19.8508866Z google.golang.org/grpc/internal/transport/networktype 2023-09-13T08:09:19.8858063Z google.golang.org/grpc/internal/resolver/unix 2023-09-13T08:09:19.9291509Z golang.org/x/text/transform 2023-09-13T08:09:20.0334302Z golang.org/x/text/unicode/bidi 2023-09-13T08:09:20.2799763Z golang.org/x/text/secure/bidirule 2023-09-13T08:09:20.3186125Z golang.org/x/text/unicode/norm 2023-09-13T08:09:20.3446639Z golang.org/x/net/trace 2023-09-13T08:09:20.5472101Z golang.org/x/net/http2/hpack 2023-09-13T08:09:20.6658097Z google.golang.org/grpc/internal/syscall 2023-09-13T08:09:20.7265610Z google.golang.org/grpc/keepalive 2023-09-13T08:09:20.7507190Z google.golang.org/grpc/peer 2023-09-13T08:09:20.7672756Z google.golang.org/grpc/stats 2023-09-13T08:09:20.7968597Z google.golang.org/grpc/tap 2023-09-13T08:09:20.8109391Z net/http/httputil 2023-09-13T08:09:20.9118860Z golang.org/x/net/idna 2023-09-13T08:09:21.0812475Z github.com/containerd/nri/pkg/log 2023-09-13T08:09:21.1106090Z github.com/containerd/nri/pkg/net 2023-09-13T08:09:21.1868485Z github.com/containerd/nri/pkg/net/multiplex 2023-09-13T08:09:21.1994754Z golang.org/x/net/http/httpguts 2023-09-13T08:09:21.2391387Z golang.org/x/net/http2 2023-09-13T08:09:21.2539725Z github.com/moby/sys/mountinfo 2023-09-13T08:09:21.3369225Z github.com/opencontainers/runtime-tools/generate/seccomp 2023-09-13T08:09:21.4597906Z github.com/syndtr/gocapability/capability 2023-09-13T08:09:21.5504667Z github.com/opencontainers/runtime-tools/validate/capabilities 2023-09-13T08:09:21.5669807Z github.com/opencontainers/runtime-tools/generate 2023-09-13T08:09:21.8891838Z github.com/containerd/nri/skel 2023-09-13T08:09:22.4377876Z google.golang.org/grpc/internal/transport 2023-09-13T08:09:23.0878320Z google.golang.org/grpc 2023-09-13T08:09:23.8771206Z k8s.io/cri-api/pkg/apis/runtime/v1 2023-09-13T08:09:26.9936794Z github.com/containerd/nri/pkg/api 2023-09-13T08:09:27.4650674Z github.com/containerd/nri/pkg/runtime-tools/generate 2023-09-13T08:09:27.4651555Z github.com/containerd/nri/pkg/adaptation 2023-09-13T08:09:27.9545705Z github.com/containerd/nri/pkg/stub 2023-09-13T08:09:28.1629452Z Building /home/runner/work/nri/nri/build/bin/logger... 2023-09-13T08:09:54.7641446Z Building /home/runner/work/nri/nri/build/bin/device-injector... 2023-09-13T08:10:20.6627223Z Building /home/runner/work/nri/nri/build/bin/hook-injector... 2023-09-13T08:10:48.2701834Z Building /home/runner/work/nri/nri/build/bin/differ... 2023-09-13T08:11:18.8316064Z Building /home/runner/work/nri/nri/build/bin/v010-adapter... 2023-09-13T08:12:13.3624114Z Building /home/runner/work/nri/nri/build/bin/template... 2023-09-13T08:12:38.4961513Z ##[error]/home/runner/go/pkg/mod/github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3/client.go:30:2: missing go.sum entry for module providing package github.com/sirupsen/logrus (imported by github.com/containerd/nri/plugins/template); to add: 2023-09-13T08:12:38.4971237Z go get github.com/containerd/nri/plugins/template 2023-09-13T08:12:38.4973529Z ##[error]/home/runner/go/pkg/mod/github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3/unixcreds_linux.go:27:2: missing go.sum entry for module providing package golang.org/x/sys/unix (imported by github.com/containerd/ttrpc); to add: 2023-09-13T08:12:38.4974700Z go get github.com/containerd/ttrpc@v1.1.1-0.20220420014843-944ef4a40df3 2023-09-13T08:12:38.4975129Z make: *** [Makefile:113: /home/runner/work/nri/nri/build/bin/template] Error 1 2023-09-13T08:12:38.4982251Z ##[error]Process completed with exit code 2. 2023-09-13T08:12:38.5070249Z Post job cleanup. 2023-09-13T08:12:38.9637515Z [command]/opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/codeql version --format=terse 2023-09-13T08:12:39.6440255Z 2.14.3 2023-09-13T08:12:40.2204778Z [command]/opt/hostedtoolcache/CodeQL/2.14.3/x64/codeql/codeql database export-diagnostics /home/runner/work/_temp/codeql_databases --db-cluster --format=sarif-latest --output=../codeql-failed-run.sarif --sarif-include-diagnostics -vvv 2023-09-13T08:12:40.83 ```

[thaJeztah]

Latest build failed because somehow, somewhere it (maybe cached again?) didn't pick up that the plugin is a separate module, so tried to build it as part of the main module;

Run make install-ginkgo test codecov
  make install-ginkgo test codecov
  shell: /usr/bin/bash -e {0}
  env:
    GOPATH: /home/runner/work/nri/nri
go: downloading github.com/containerd/ttrpc v1.1.1-0.20220420014843-944ef4a40df3
go: downloading golang.org/x/sys v0.1.0
go: downloading github.com/opencontainers/runtime-spec v1.0.3-0.20220825212826-86290f6a00fb
go: downloading github.com/sirupsen/logrus v1.8.1
go: downloading github.com/moby/sys/mountinfo v0.6.2
go: downloading github.com/opencontainers/runtime-tools v0.0.0-20221026201742-946c877fa809
go: downloading google.golang.org/protobuf v1.28.1
go: downloading k8s.io/cri-api v0.25.3
go: downloading google.golang.org/genproto v0.0.0-20220502173005-c8bf987b8c21
go: downloading google.golang.org/grpc v1.47.0
go: downloading github.com/gogo/protobuf v1.3.2
go: downloading github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635
go: downloading golang.org/x/net v0.1.0
go: downloading github.com/golang/protobuf v1.5.2
go: downloading golang.org/x/text v0.4.0
go: downloading github.com/onsi/ginkgo/v2 v2.5.0
go: downloading github.com/go-task/slim-sprig v0.0.0-20210107165309-348f09dbbbc0
go: downloading golang.org/x/tools v0.2.0
go: downloading github.com/google/pprof v0.0.0-20210407192527-94a9f03dee38
Will skip:
  ./plugins/ulimit-adjuster
go: downloading github.com/onsi/gomega v1.24.0
go: downloading sigs.k8s.io/yaml v1.3.0
go: downloading github.com/go-logr/logr v1.2.3
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/google/go-cmp v0.5.9
go: downloading gopkg.in/yaml.v3 v3.0.1

[1694595045] NRI Runtime - 81/81 specs ••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••• SUCCESS! 533.630306ms PASS
coverage: 78.5% of statements
go: downloading github.com/stretchr/testify v1.8.0
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/davecgh/go-spew v1.1.1

[1694595045] Net pre-connected Connections and SocketPair - 0/0 specs  SUCCESS! 258.505µs PASS
coverage: 59.1% of statements
[1694595045] Connection Multiplexer - 12/12 specs •••••••••••• SUCCESS! 50.669488ms PASS
coverage: 72.0% of statements
[1694595045] Generate Suite - 10/10 specs •••••••••• SUCCESS! 3.368264ms PASS
coverage: 38.3% of statements
composite coverage: 70.9% of statements

Ginkgo ran 4 suites in 32.652418511s
Test Suite Passed
main module (github.com/containerd/nri) does not contain package github.com/containerd/nri/plugins/ulimit-adjuster
make: *** [Makefile:139: test-ulimits] Error 1
Error: Process completed with exit code 2.

[thaJeztah]

Oh, maybe I see; makefile needs a new entry because it's a separate module now. Let me fix

[thaJeztah]

Alright; all green now! I can move the first commit to a separate PR for visibility; also did a quick try in containerd if everything looks good, and so far (CI still running) I think it does;

• https://github.com/containerd/containerd/pull/9091

[thaJeztah]

And opened a separate PR for the first commit;

• https://github.com/containerd/nri/pull/54

[thaJeztah]

@klihub @samuelkarp I moved this one out of draft 👍

[thaJeztah]

Happy to do follow-ups where needed! I honestly am not familiar with this module (at all!) and my changes were really just to simplify containerd's complex dependency tree (and to cut circular references where possible)

[klihub]

Happy to do follow-ups where needed! I honestly am not familiar with this module (at all!) and my changes were really just to simplify containerd's complex dependency tree (and to cut circular references where possible)

Sorry if my comment was confusing. I think these changes are fine.

[thaJeztah]

no worries! I think I understood it was not a blocker, so no harm done!