search

containerd / nri

Node Resource Interface
Apache License 2.0
238 stars 62 forks source link

(testing): go.mod: downgrade ttrpc to latest v1.1.x release #70

Closed thaJeztah closed 7 months ago

thaJeztah commented 7 months ago

downgrade the minimum required version to v1.1.1. consumers of this module can pick higher versions to match their requirements.

thaJeztah commented 7 months ago

just testing if this would work 😅

thaJeztah commented 7 months ago

Looks like we need v1.2.0 as a minimum (https://github.com/containerd/ttrpc/commit/d28bc9265738379b9f0383bc9facb2f28e877285 is v1.2.0 and up);

Error: pkg/api/api_ttrpc.pb.go:16:6: srv.RegisterService undefined (type *ttrpc.Server has no field or method RegisterService)
Error: pkg/api/api_ttrpc.pb.go:73:6: srv.RegisterService undefined (type *ttrpc.Server has no field or method RegisterService)
make: *** [Makefile:77: build-check] Error 1
Error: Process completed with exit code 2.
thaJeztah commented 7 months ago

And I see v1.2.3 was tagged; https://github.com/containerd/ttrpc/releases/tag/v1.2.3

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bac4892) 64.44% compared to head (ebf4ba0) 64.55%.

:exclamation: Current head ebf4ba0 differs from pull request most recent head a38edc6. Consider uploading reports for the commit a38edc6 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #70 +/- ## ========================================== + Coverage 64.44% 64.55% +0.10% ========================================== Files 10 10 Lines 1845 1845 ========================================== + Hits 1189 1191 +2 + Misses 505 503 -2 Partials 151 151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.