search

containerd / nri

Node Resource Interface
Apache License 2.0
238 stars 62 forks source link

network device injector plugin #82

Closed aojea closed 4 months ago

aojea commented 4 months ago

The network device inject plugin allow to inject network interfaces that are present in the host to the Pods.

The network interface can be renamed and a network configuration can be passed.

It is important to differentiate between network interface injection and CNI, as today, CNI is used for container runtimes to provider the network configuration, it performs also the creation and the configuration of the interfaces that are injected into the Pod namespace and provide as a result some properties like the assiged IPs that are consumed later by the upstream projects like Kubernetes.

aojea commented 4 months ago

/assign @samuelkarp

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.31%. Comparing base (53d3371) to head (4d4784d). Report is 2 commits behind head on main.

:exclamation: Current head 4d4784d differs from pull request most recent head 0b32005. Consider uploading reports for the commit 0b32005 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #82 +/- ## ========================================== - Coverage 64.55% 57.31% -7.24% ========================================== Files 10 4 -6 Lines 1845 1305 -540 ========================================== - Hits 1191 748 -443 + Misses 503 430 -73 + Partials 151 127 -24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aojea commented 4 months ago

Can you squash the commits? I don't think there's value in preserving these intermediates.

done, I just kept them to simplify the review, so you can see the changes :) squasshed