search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

`go get github.com/containerd/nydus-snapshotter@latest` refers to a non-existent version (v0.11.3) #535

Closed AkihiroSuda closed 1 year ago

AkihiroSuda commented 1 year ago 
$ go version
go version go1.21.1 linux/amd64

$ go get github.com/containerd/nydus-snapshotter@latest
go: downloading github.com/containerd/nydus-snapshotter v0.11.3
go: added github.com/containerd/nydus-snapshotter v0.11.3

This revision does not seem to exist. The actual latest revision in https://github.com/containerd/nydus-snapshotter/tags seems v0.10.0.

imeoer commented 1 year ago

cc @changweige PTAL

imeoer commented 1 year ago

https://proxy.golang.org/github.com/containerd/nydus-snapshotter/@v/list It seems to have some broken versions cached in the go module proxy.

changweige commented 1 year ago

The wrongly released versions have already been retracted from go.mod


retract (
    v0.11.3
    v0.11.2
    v0.11.1
    v0.11.0
    v0.3.0 // retagged: cd604c1b597558ea045a79c4f80a8c780909801b -> 85653575c7dafb6b06548478ee1dc61ac5905d00
)```
thaJeztah commented 1 year ago

Wondering if it is because the version that retracts them is older than v0.11.0,

Maybe the best way forward is to tag a v0.12.0 release, so that latest is what can safely be used

thaJeztah commented 1 year ago

I guess I should also mention that v0.11 can no longer be used as version; I see v0.10 was released recently, and v0.11 should be skipped now

imeoer commented 1 year ago

@thaJeztah +1, let's do that.

imeoer commented 1 year ago

Now we have the latest version https://github.com/containerd/nydus-snapshotter/releases/tag/v0.12.0

$ go get github.com/containerd/nydus-snapshotter@latest
go: downloading github.com/containerd/nydus-snapshotter v0.12.0

Thanks for the bug report cc @AkihiroSuda @thaJeztah

thaJeztah commented 1 year ago

Thanks! I see a v0.12.0 tag was created; https://github.com/containerd/nydus-snapshotter/releases/tag/v0.12.0

🤞 hope that helps with the situation (but I think it does)

thaJeztah commented 1 year ago

Quick check; looks like it does 👍 

docker run --rm -w /foo golang:1.20 sh -c 'go mod init foo && go get github.com/containerd/nydus-snapshotter@latest'
go: creating new go.mod: module foo
go: downloading github.com/containerd/nydus-snapshotter v0.12.0
go: added github.com/containerd/nydus-snapshotter v0.12.0
AkihiroSuda commented 1 year ago

Thank you!