search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
172 stars 99 forks source link

fix: update windows public functions to match linux #537

Closed jedevc closed 1 year ago

jedevc commented 1 year ago

Previously, the function signatures differed after being updated in b16a06858426dd2034bc361cb29805734e32d7c3. This patch updates the corresponding windows functions to match the linux signatures.

Discovered this in BuildKit when attempting to enable linting for Windows: https://github.com/moby/buildkit/pull/4261

jedevc commented 1 year ago

@imeoer @changweige

changweige commented 1 year ago

Looks like CI is failing, I will take a look. It should not relate to this PR :-)

jedevc commented 1 year ago

Any chance this could be cherry-picked to a release branch so we could pull it into buildkit?

I think we're on the v0.8 branch in buildkit, last updated in https://github.com/moby/buildkit/pull/3892.

changweige commented 1 year ago

Any chance this could be cherry-picked to a release branch so we could pull it into buildkit?

I think we're on the v0.8 branch in buildkit, last updated in moby/buildkit#3892.

@jedevc Sure, I will release the next version of nydus-snapshotter soon

changweige commented 1 year ago

@jedevc Hello, we have released v0.13.0