search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

e2e: always disable erofs ondemand-read test and failover test #540

Closed changweige closed 1 year ago

changweige commented 1 year ago

Github action has upgraded its worker kernel to 6.2 with CONFIG_EROFS_FS_ONDEMAND enabled. The e2e tests of failover depends on private kernel patches rather upstream kernel. So we have to totally disable the failover tests for now

codecov[bot] commented 1 year ago

Codecov Report

Merging #540 (62f53c7) into main (9a2575b) will decrease coverage by 3.99%. Report is 18 commits behind head on main. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/540/graphs/tree.svg?width=650&height=150&src=pr&token=R3RX5WX6R1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) ```diff @@ Coverage Diff @@ ## main #540 +/- ## ========================================== - Coverage 37.55% 33.56% -3.99% ========================================== Files 60 65 +5 Lines 7139 8175 +1036 ========================================== + Hits 2681 2744 +63 - Misses 4146 5116 +970 - Partials 312 315 +3 ``` [see 15 files with indirect coverage changes](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/540/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)
sctb512 commented 1 year ago

Sometimes, the optimizer test also fails. It seems we should verify if the containerd is ready before generating the accessed list. I will post a PR soon for it.