search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

release: Upload s390x tarball #552

Closed fidencio closed 1 year ago

fidencio commented 1 year ago

This series is the very start to allow shipping tarball including binaries for different architectures than x86_64.

The focus here is s390x, which is used by Confidential Containers, but this can easily be expanded in the future.

Last but not least, for now we have no interest in publishing a multi-architecture image.

Fixes: https://github.com/containerd/nydus-snapshotter/issues/548

fidencio commented 1 year ago

https://github.com/fidencio/nydus-snapshotter/actions/runs/6670584297 is an example of the action successfully running.

fidencio commented 1 year ago

Ideally, we'd need a release as soon as this one gets merged. :-)

fidencio commented 1 year ago

/cc @bergwolf

bergwolf commented 1 year ago

Unfortunately, we haven't provided s390x nydusd yet. And there's a build failure on s390x. See https://github.com/cloud-hypervisor/fuse-backend-rs/pull/170

fidencio commented 1 year ago

Unfortunately, we haven't provided s390x nydusd yet

Yep, that's the reason I am avoiding to even try to provide the image for different arches. But, out of curiosity, how does this block the nydus-snapshotter tarball release for s390x?

Asking as we've been using that (built by myself) as part of the CoCo CI already :-)

bergwolf commented 1 year ago

@fidencio No, it does not block this PR but nydus-snapshotter does not work w/o nydusd. So the functionality is still blocked.

fidencio commented 1 year ago

@fidencio No, it does not block this PR but nydus-snapshotter does not work w/o nydusd. So the functionality is still blocked.

It actually does for the confidential containers use case we don't actually need nydusd for pulling the image in the guest.

fidencio commented 1 year ago

I'm closing this one in favour of #553.