search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
156 stars 88 forks source link

daemon: change `amplify_io` into nullable int #554

Closed hangvane closed 8 months ago

hangvane commented 8 months ago

amplify_io should be nullable in config file. The absence of amplify_io in the config file means it follows the default value in nydusd, i.e., 1M. amplify_io=0 means it is set to zero. So let's change this field into nullable to pass the value as what it is read from template config file.

codecov[bot] commented 8 months ago

Codecov Report

Merging #554 (b0a0d9d) into main (bd47e03) will increase coverage by 0.02%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/554/graphs/tree.svg?width=650&height=150&src=pr&token=R3RX5WX6R1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) ```diff @@ Coverage Diff @@ ## main #554 +/- ## ========================================== + Coverage 33.61% 33.63% +0.02% ========================================== Files 65 65 Lines 8259 8259 ========================================== + Hits 2776 2778 +2 + Misses 5167 5166 -1 + Partials 316 315 -1 ``` | [Files](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [config/daemonconfig/fuse.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-Y29uZmlnL2RhZW1vbmNvbmZpZy9mdXNlLmdv) | `0.00% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/554/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)