search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
156 stars 88 forks source link

action: update nodejs20 #578

Closed Desiki-high closed 4 months ago

Desiki-high commented 5 months ago
  1. use nodejs 20 version action: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/ .
  2. update golangci-lint v1.55.2 and use official GitHub action for golangci-lint.
  3. use setup-go @v5 native cache ability.
  4. fix lint errors.
imeoer commented 5 months ago

@Desiki-high LGTM! Sorry for the conflicts, let's resolve them first.

Desiki-high commented 5 months ago

@imeoer Please help to update the release.yml later, if you have the write access.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (3fcac86) 33.52% compared to head (9dd0af7) 34.64%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578/graphs/tree.svg?width=650&height=150&src=pr&token=R3RX5WX6R1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) ```diff @@ Coverage Diff @@ ## main #578 +/- ## ========================================== + Coverage 33.52% 34.64% +1.12% ========================================== Files 65 65 Lines 8287 6552 -1735 ========================================== - Hits 2778 2270 -508 + Misses 5194 3967 -1227 Partials 315 315 ``` | [Files](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [pkg/store/database\_compat.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL3N0b3JlL2RhdGFiYXNlX2NvbXBhdC5nbw==) | `78.19% <100.00%> (+1.54%)` | :arrow_up: | | [config/daemonconfig/fuse.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-Y29uZmlnL2RhZW1vbmNvbmZpZy9mdXNlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/auth/keychain.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL2F1dGgva2V5Y2hhaW4uZ28=) | `31.48% <0.00%> (+3.54%)` | :arrow_up: | | [pkg/daemon/daemon.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL2RhZW1vbi9kYWVtb24uZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/store/database.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL3N0b3JlL2RhdGFiYXNlLmdv) | `48.68% <75.00%> (+4.52%)` | :arrow_up: | | [pkg/system/system.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL3N5c3RlbS9zeXN0ZW0uZ28=) | `6.16% <0.00%> (+1.36%)` | :arrow_up: | ... and [55 files with indirect coverage changes](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/578/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)