search

containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

misc: merge chmod into copy in Dockerfile #600

Closed SToPire closed 4 months ago

SToPire commented 4 months ago

Let's use Docker's COPY --chmod feature instead of using a separate chmod command. This will reduce the generated image size by ~12KB.

Fixes: #402

imeoer commented 4 months ago

Not sure the broken CI is related with the PR.

SToPire commented 4 months ago

Sorry for the late reply! It seems that COPY --chmod in Docker buildkit only supports octal notation instead of "+x". [1]

This was my mistake and I've updated the new patch. It looks like the current version could pass the CI correctly.

[1] https://docs.docker.com/reference/dockerfile/#copy