containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

CI fix, part I: update and cleanup #606

Closed apostasie closed 3 months ago

apostasie commented 4 months ago

Work on #604 required a set of changes, fixes and updates to the test rig and CI, and has grown really large.

This PR does split out some of the more minor changes to make it easier to review.

Furthermore, the CI is in a shaky state right now and is just red, as the build fails because of delve latest being dependent on a more recent version of go (which in turns requires a series of changes), and also as #603 seems to break e2e kube tests (or this test is very flaky).

Changes:

apostasie commented 4 months ago

@imeoer fixing kube tests will take more work, that I would like to do in a separate PR, so, I am removing my "kube" commit from here for now.

This here is just dealing with the rest.

Do you mind having a look at this at your convenience so that we can rebase other ongoing work? I believe this will fix a bunch of CI issues.

apostasie commented 4 months ago

Also, I did split "unrelated" changes into separate commits so that "history" is easier to review, but of course happy to squash if you prefer that.

apostasie commented 4 months ago

Note: we might want to pin delve to a specific version to avoid being forced into the same situation wrt golang version later on.

imeoer commented 3 months ago

LGTM, thanks for the hard work!

apostasie commented 3 months ago

You welcome @imeoer :)