search

containerd / project-checks

This cross-project repository holds utilities, scripts, and common files used across the containerd master project and many sub-projects within the containerd organization
Apache License 2.0
5 stars 10 forks source link

Add license checker #10

Closed AkihiroSuda closed 7 months ago

AkihiroSuda commented 1 year ago

Probably we can use https://github.com/google/go-licenses

e.g., https://github.com/lima-vm/lima/pull/1832/files

coderbirju commented 8 months ago

Hey there,

I'd like to take this issue up.

Following @AkihiroSuda 's advice I made some changes to the yaml file in my fork of project-checks. However I'm running into issues testing this change.

Steps:

  1. Created a fork of containerd/project-checks and merged the necessary updates to the action.yml file
  2. Generated binaries of the project-checks repository
  3. Updated the binaries in the ci.yml file in my forked repo of containerd

I wanted to know if I'm on the right track. Is there a better way to test these changes? Would appreciate any insights. Thanks!

coderbirju commented 7 months ago

Was able to figure this out.

PR #11

Testing: Successful workflow run

coderbirju commented 7 months ago

Could we maybe add a CI workflow that could test changes to project-checks with all of the dependent repos? Also an update to the tags in the repos is required, maybe we can automate that as well?

Tracking this in #12

estesp commented 7 months ago

Solved via #11