search

containerd / project-checks

This cross-project repository holds utilities, scripts, and common files used across the containerd master project and many sub-projects within the containerd organization
Apache License 2.0
5 stars 10 forks source link

if vendor script detects modified files, show diff #3

Closed alakesh closed 3 years ago

alakesh commented 3 years ago

Showing the content of the diff helps debugging.

Signed-off-by: Alakesh Haloi alakeshh@amazon.com

notes: Sometimes project check fails in github builds indicating file modifications not in commit. But in local builds, those files are not shown modified outside of the commit. Being able to check the diff content in build artifact's raw content will greatly reduce time to debug such issues.

estesp commented 3 years ago

@mxpv if I remember correctly from the last time, we probably need a branch at some point so that references to this action don't have to specify a tag (e.g. v1.0.2) to use "new features" in the action. I think you have to name the branch v1 for example, to get anyone currently using this version to automatically start using anything merged to that branch?

mxpv commented 3 years ago

@estesp Yep, branch option is the easiest. According to this: https://docs.github.com/en/actions/creating-actions/about-actions#using-branches-for-release-management We can just have v1 branch and merge changes there whenever we ready to publish them.