Fix image name of test-image/oci

containerd / runwasi

Facilitates running Wasm / WASI workloads managed by containerd

Apache License 2.0

1.02k stars 84 forks source link

Fix image name of test-image/oci #434

Closed sachaos closed 6 months ago

sachaos commented 6 months ago

The image name expected in https://github.com/containerd/runwasi/blob/ec3d24d9abf0ff007ab56d07fbe040b1753d6b20/README.md#L289 is ghcr.io/containerd/runwasi/wasi-demo-oci. But the image name created by make test-image/oci is wasi-demo-app. So I've fixed the image name to wasi-demo-oci.

Signed-off-by: Takumasa Sakao tsakao@zlab.co.jp

sachaos commented 6 months ago

@Mossaka Thank you for your review! I've fixed the CI. 😄

jsturtevant commented 6 months ago

sorry I didn't see this last week when I got back. I think this should have been an update to the README not the make files. CI was passing it was just the readme that was off

jprendes commented 6 months ago

I think this should have been an update to the README not the make files.

I prefer the current change. IIUC, before both (distinct) images were using the same name, right? I think it's cleaner to give them different names, specially for local development.

jsturtevant commented 6 months ago

works for me