Closed devigned closed 6 months ago
devigned
commented
7 months ago The dry run for the release workflow passes https://github.com/containerd/runwasi/actions/runs/8124152176. Via the cron scheduling we should get early warning to when failures are introduced.
I intend on following this release workflow with additional release flow changes that will automate the cargo versioning.
jsturtevant
commented
6 months ago anything holding this up besides a rebase? this would have been handy since our latest release failed :-( https://github.com/containerd/runwasi/actions/runs/8351251493
devigned
commented
6 months ago anything holding this up besides a rebase? this would have been handy since our latest release failed :-( https://github.com/containerd/runwasi/actions/runs/8351251493
I was having something of an existential crisis about this PR and if it would actually help us. Can you drop the link for the failed release? I'll make sure it is something the job would catch and prep the PR for merge.
jsturtevant
commented
6 months ago Whys that? Either something that runs dry-run regularly like this or a step before publishing would help I think.
I also think we should reorder the publish steps so we don't create a release before the crate is published or we end up with an release in github that isn't in crates.io like https://github.com/containerd/runwasi/releases/tag/containerd-shim-wasm%2Fv0.5.0
The failed release is https://github.com/containerd/runwasi/actions/runs/8351251493
This PR adds a dry run option to the release workflow and enables workflow_dispatch and nightly cron scheduling to ensure the release workflow is consistently in a working state.
The cron and workflow_dispatch triggers will trigger the workflow to execute in dry run mode. In this mode, the workflow will not push artifacts or crates. By default it will select the most recent tag for its ref to build.