containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

feat: Add helper script to aid in keeping proto files up to date #202

Closed bryantbiggs closed 9 months ago

bryantbiggs commented 1 year ago

Open to thoughts/feedback - and I've loved to help document some of this once its ironed out

jsturtevant commented 1 year ago

2. I suspect I am doing something wrong or mis-understanding because where is github.com/containerd/cgroups/v3 ?! I see it used here and referenced across the contaienrd project but I don't see where that v3 is located or coming from. If I go to the cgroups repository I only see cgroups1/, cgroups2/ and cmd/ directories

This took me a while to figure out too, It is coming from https://github.com/containerd/cgroups/blob/v3.0.2/go.mod#L1

bryantbiggs commented 1 year ago

I need to revisit this when I get some time - it doesn't work well across platform (Linux vs MacOS) as its written

mxpv commented 9 months ago

This was solved in https://github.com/containerd/rust-extensions/pull/244, so I'm going to close this one. Let us know if there any missing bits left.