Closed bryantbiggs closed 9 months ago
2. I suspect I am doing something wrong or mis-understanding because where is
github.com/containerd/cgroups/v3
?! I see it used here and referenced across thecontaienrd
project but I don't see where thatv3
is located or coming from. If I go to thecgroups
repository I only seecgroups1/
,cgroups2/
andcmd/
directories
This took me a while to figure out too, It is coming from https://github.com/containerd/cgroups/blob/v3.0.2/go.mod#L1
I need to revisit this when I get some time - it doesn't work well across platform (Linux vs MacOS) as its written
This was solved in https://github.com/containerd/rust-extensions/pull/244, so I'm going to close this one. Let us know if there any missing bits left.
containerd
organization, but can be extended to the other vendored sources if this seems valuable/usefulcgroups
:v1
andv2
are being pulled in so they have been namespaced under their respective version. Since the existing implementation is usingv1
, that has been maintained through this change. In a later PR, we can look at if/how to exposev2
to users behind a feature flaggithub.com/containerd/cgroups/v3
?! I see it used here and referenced across thecontaienrd
project but I don't see where thatv3
is located or coming from. If I go to thecgroups
repository I only seecgroup1/
,cgroup2/
andcmd/
directoriesOpen to thoughts/feedback - and I've loved to help document some of this once its ironed out