search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

Support client create on Windows #205

Closed jsturtevant closed 7 months ago

jsturtevant commented 1 year ago

Allow for using the client create on Windows (https://github.com/containerd/rust-extensions/tree/main/crates/client). Currently it fails to build with:

error[E0432]: unresolved import `tokio::net::UnixStream`
  --> C:\Users\jstur\.cargo\registry\src\index.crates.io-6f17d22bba15001f\containerd-client-0.4.0\src\lib.rs:81:9
   |
81 |     use tokio::net::UnixStream;
   |         ^^^^^^^^^^^^^^^^^^^^^^ no `UnixStream` in `net`
   |
note: found an item that was configured out
  --> C:\Users\jstur\.cargo\registry\src\index.crates.io-6f17d22bba15001f\tokio-1.32.0\src\net\mod.rs:51:27
   |
51 |     pub use unix::stream::UnixStream;
   |                           ^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `containerd-client` (lib) due to previous error
make: *** [Makefile:32: build-wasm] Error 101
Redent0r commented 11 months ago

Hi @jsturtevant and @mxpv ! I recently encountered the exact same issue. Do you know of any plans in motion to add Windows support? Thanks!

jsturtevant commented 11 months ago

I don't believe anyone is working on it right now, if you are interested in picking it up.

jsturtevant commented 7 months ago

I've got this working and will submit a PR soon