search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

Update containerd versions on CI #222

Closed mxpv closed 9 months ago

jsturtevant commented 11 months ago

hmm looks like it failed with 

 container_linux_test.go:1582: 
2023-12-07T19:24:14.7281890Z            Error Trace:    /home/runner/work/rust-extensions/rust-extensions/src/github.com/containerd/containerd/integration/client/container_linux_test.go:1582
2023-12-07T19:24:14.7282958Z            Error:          Received unexpected error:
2023-12-07T19:24:14.7284193Z                            failed to create shim task: Others("Other: unable to create runc instance: Unable to locate the runc"): unknown
2023-12-07T19:24:14.7285214Z            Test:           TestIssue9103/should_be_stopped_status_if_init_has_been_killed
2023-12-07T19:24:14.7311011Z --- FAIL: TestIssue9103 (0.09s)
2023-12-07T19:24:14.7312787Z     --- PASS: TestIssue9103/should_be_created_status (0.06s)
2023-12-07T19:24:14.7314580Z     --- FAIL: TestIssue9103/should_be_stopped_status_if_init_has_been_killed (0.03s)
jsturtevant commented 11 months ago

may be worth restarting ci now after #225

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cffe94b) 37.98% compared to head (a0dea34) 37.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 37.98% 37.98% ======================================= Files 55 55 Lines 5060 5060 ======================================= Hits 1922 1922 Misses 3138 3138 ``` | [Flag](https://app.codecov.io/gh/containerd/rust-extensions/pull/222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/containerd/rust-extensions/pull/222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | `37.98% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mxpv commented 9 months ago

Added v1.6.28, v1.7.13, and v2.0.0-beta.2. @jsturtevant could you pls take another look?