search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

Remove read_file_to_str helper #245

Closed mxpv closed 5 months ago

mxpv commented 9 months ago

Use fs::read_to_string from stdlib/tokio instead.

codecov-commenter commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (cc445f5) 38.08% compared to head (8753903) 38.02%.

Files Patch % Lines
crates/shim/src/asynchronous/util.rs 20.00% 4 Missing :warning:
crates/runc-shim/src/runc.rs 0.00% 2 Missing :warning:
crates/shim/src/asynchronous/mod.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #245 +/- ## ========================================== - Coverage 38.08% 38.02% -0.06% ========================================== Files 55 55 Lines 5099 5086 -13 ========================================== - Hits 1942 1934 -8 + Misses 3157 3152 -5 ``` | [Flag](https://app.codecov.io/gh/containerd/rust-extensions/pull/245/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/containerd/rust-extensions/pull/245/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | `38.02% <12.50%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.