search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

Fix command fds in sync version of the shim #253

Closed mxpv closed 8 months ago

mxpv commented 8 months ago

Looks like we need to apply the patch https://github.com/containerd/rust-extensions/pull/251 for sync version as well to fix publishing https://github.com/containerd/rust-extensions/pull/252

jsturtevant commented 8 months ago

do we need to update CI so it catches this?

mxpv commented 8 months ago

do we need to update CI so it catches this?

Yeah. runc-shim uses async portion of the shim crate, leaving sync untested.