search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

runc: split Pipe, Io, and PipedIo to async and sync modules #335

Open Mossaka opened 3 weeks ago

Mossaka commented 3 weeks ago

An attempt to resolve https://github.com/containerd/rust-extensions/pull/326#issuecomment-2458210761

Questions: should we add cargo build -p runc to the CI since the CI is not building runc with default target at all?

Can you take a look at this PR? @ningmingxiao, @mxpv

jokemanfire commented 3 weeks ago

I think this change is great ,but how about using pipe but not using fifo directly, because there's so many problem which I meet in FIFO direct. #278

Mossaka commented 3 weeks ago

My goal is to do a refactoring so that the code can compile. I am happy to rebase on your Pr if that works

jokemanfire commented 3 weeks ago

My goal is to do a refactoring so that the code can compile. I am happy to rebase on your Pr if that works

I think I should wait for your split , because I forget the sync feature too, that pipe problem is only existing in async feature.

mxpv commented 2 weeks ago

Questions: should we add cargo build -p runc to the CI since the CI is not building runc with default target at all?

I wonder why is it not included. On Linux, the entire Cargo workspace should be included?

Mossaka commented 1 week ago

I was AFK this entire week. Will follow up to address the comments when I get back to work.

Mossaka commented 1 week ago

I think I should wait for your spli

Okay, I will leave my PR to merge as it is, and the issue regarding FIFO could be left to a follow up. I don't want to block your PR

Mossaka commented 1 week ago

I wonder why is it not included. On Linux, the entire Cargo workspace should be included?

I think we are missing a --workspace flag on ci.yml

Mossaka commented 11 hours ago

Can we merge this PR now? @mxpv