Closed powturns closed 1 year ago
Base: 25.95% // Head: 25.95% // No change to project coverage :thumbsup:
Coverage data is based on head (
d31099a
) compared to base (8c27584
). Patch coverage: 100.00% of modified lines in pull request are covered.:exclamation: Current head d31099a differs from pull request most recent head 15fe7ed. Consider uploading reports for the commit 15fe7ed to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
It seems like clippy got new lints in 1.65 which is causing unchanged parts of this PR to fail the build.
I previously had attempted to fix some of these in an isolated commit, but now I believe the volume of them warrants a separate merge request.
@powturns Thank you for your pull request and sorry for the late response, We will review it ASAP.
@mxpv @lifupan @liubin would you mind taking a look at this patch? thank you!
Any opinions on how to resolve the clippy errors? Should I rebase on top of something?
@powturns there is a hint about how to fix:
error: the borrowed expression implements the required traits --> build.rs:17:17 17 .inputs(&["src/ttrpc.proto"]) ^^^^^^^^^^^^^^^^^^^^ help: change this to: ["src/ttrpc.proto"]
= note:
-D clippy::needless-borrow
implied by-D warnings
Would you like me do the fixes in this MR? Do you know if the lint failures are due to new linting rules or due to new language features in 1.65? My concern would be by fixing some of the lint failures, I inadvertently increase the minimum rust version.
@powturns We do not specify a Rust version in GitHub actions, it may be the reason that leads to this clippy warning @Tim-Zhang .
And I think you can add a separate commit to fix the clippy warning in shit PR.
@powturns @liubin We already have a pr https://github.com/containerd/ttrpc-rust/pull/166 which try to fix it. Though it has some problems, I think we could wait for the author one or two days.
And I will force merge this by ignoring CI errors.
AOSP has vsock support via the cuttlefish hypervisor. This PR enables vsock functionality on android, in addition to linux.