containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Add new api for creating client #181

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

When adding windows implementation the new_client call had a possibility of failing so the result was wrapped in a Result. This caused the existing api to use a unwrap_or_else and panic since we couldn't pass the result onto the user.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.37 :warning:

Comparison is base (34003e3) 25.76% compared to head (6639bca) 24.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #181 +/- ## ========================================== - Coverage 25.76% 24.39% -1.37% ========================================== Files 16 17 +1 Lines 2395 2529 +134 ========================================== Hits 617 617 - Misses 1778 1912 +134 ``` | [Impacted Files](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/asynchronous/client.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2FzeW5jaHJvbm91cy9jbGllbnQucnM=) | `0.00% <0.00%> (ø)` | | | [src/asynchronous/stream.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2FzeW5jaHJvbm91cy9zdHJlYW0ucnM=) | `0.00% <0.00%> (ø)` | | | [src/common.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2NvbW1vbi5ycw==) | `35.57% <ø> (ø)` | | | [src/error.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2Vycm9yLnJz) | `55.55% <ø> (ø)` | | | [src/lib.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | | | [src/sync/channel.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvY2hhbm5lbC5ycw==) | `0.00% <0.00%> (ø)` | | | [src/sync/client.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvY2xpZW50LnJz) | `0.00% <0.00%> (ø)` | | | [src/sync/server.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvc2VydmVyLnJz) | `0.00% <0.00%> (ø)` | | | [src/sync/sys/unix/net.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvc3lzL3VuaXgvbmV0LnJz) | `0.00% <0.00%> (ø)` | | | [src/sync/utils.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/181?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvdXRpbHMucnM=) | `0.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.