search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Why did containerd delete all my permissions from ttrpc-rust #187

Closed Tim-Zhang closed 1 year ago

Tim-Zhang commented 1 year ago

As a core maintainer of ttrpc-rust I found that my permissions in ttrpc-rust has gone. I don't know why this could happen without even a single notify, I want to know who did this and why.

The only thing I know is @fuweid told me that containerd will take action to change permission management to non-core project hours ago through Wechat.

fuweid commented 1 year ago

I think it is related to security concern. Thanks for your contribution to ttrpc-rust project. I suggest that the admin permissions should be assigned to maintainers who is in the https://github.com/containerd/ttrpc-rust/blob/master/MAINTAINERS, which is trustable. It's also helpful to new contributor. Like nerdctl project, they files a pull-request to promote contributor as reviewer. I will file a pr to promote you as maintainer and add @wllenyj as reviewer, because of high activity and contribution.

And we have https://github.com/containerd/project/blob/main/GOVERNANCE.md#stepping-down-policy for inactive maintainer right now. We can revisit it later.

dmcgowan commented 1 year ago

@Tim-Zhang sorry about that, that was me. I bumped any outside collaborator with admin access to maintain access as part of a permission audit we were doing. I realize it may not have been communicated clearly about timing, but looks like we are getting it straightened out in the MAINTAINERS file now. I have created the teams in our Github org to reflect that. The @containerd/ttrpc-rust-committers team for maintain permissions and @containerd/ttrpc-rust-reviewers for triage.

Tim-Zhang commented 1 year ago

@dmcgowan That's OK, thank you for your explanation. I am very glad to cooperate with this change in permissions.