search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

fix timing issue of streaming #220

Closed abel-von closed 3 days ago

abel-von commented 6 months ago

The stream request and data is handle asynchronously, if the data is handled when stream is not created yet, the data will be discarded and an error occur.

we should wait until the stream is created and then the subsequent message can be handled.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 25.22%. Comparing base (a9198f2) to head (431bfb8). Report is 11 commits behind head on master.

:exclamation: Current head 431bfb8 differs from pull request most recent head 59c3b3e. Consider uploading reports for the commit 59c3b3e to get more accurate results

Files Patch % Lines
src/asynchronous/server.rs 0.00% 16 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #220 +/- ## ========================================== + Coverage 24.97% 25.22% +0.25% ========================================== Files 16 16 Lines 2651 2704 +53 ========================================== + Hits 662 682 +20 - Misses 1989 2022 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsturtevant commented 6 months ago

looks like ci is failing with https://github.com/containerd/ttrpc-rust/issues/219

abel-von commented 4 months ago

code is rebased, please take a look. and CI error of Coverage seems a network error? @jsturtevant