search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Fix android build #224

Closed powturns closed 6 months ago

powturns commented 7 months ago

Android target fails to compile as fd is not defined.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.97%. Comparing base (486b4e8) to head (a9198f2). Report is 1 commits behind head on master.

:exclamation: Current head a9198f2 differs from pull request most recent head b5cbdcc. Consider uploading reports for the commit b5cbdcc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #224 +/- ## ======================================= Coverage 24.97% 24.97% ======================================= Files 16 16 Lines 2651 2651 ======================================= Hits 662 662 Misses 1989 1989 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jsturtevant commented 7 months ago

LGTM

needs https://github.com/containerd/ttrpc-rust/pull/223 before this will be green @Tim-Zhang @wllenyj

wllenyj commented 7 months ago

do a rebase?

wllenyj commented 6 months ago

maybe tokens is required by coverage CI.

[2024-04-28T01:57:21.081Z] ['error'] There was an error running the uploader: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 429 - {'detail': ErrorDetail(string='Rate limit reached. Please upload with the Codecov repository upload token to resolve issue. Expected available in 1322 seconds.', code='throttled')}