search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Codegen: convert Arc<Box<T>> to Arc<T> #235

Closed Xynnn007 closed 1 month ago

Xynnn007 commented 3 months ago

This commit changes the generated ttrpc server from Arc<Box> to Arc. This helps the type conversion and also avoids extra runtime cost caused by double pointer.

Fixes #234

Xynnn007 commented 2 months ago

@wllenyj sry please wait a moment. Let me test locally if sync version works fine with this.

Xynnn007 commented 2 months ago

@wllenyj Add the line of sync version create_xxx_server

Xynnn007 commented 2 months ago

Hi @wllenyj @Tim-Zhang What should I do else to move this forward?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 24.74%. Comparing base (a9198f2) to head (444a490). Report is 17 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #235 +/- ## ========================================== - Coverage 24.97% 24.74% -0.23% ========================================== Files 16 16 Lines 2651 2675 +24 ========================================== Hits 662 662 - Misses 1989 2013 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.