search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Update timeout to infinite for poll of accept #249

Closed Tim-Zhang closed 1 month ago

Tim-Zhang commented 1 month ago

It should be a mistake to modify it from -1 to 10 in the PR #226 https://github.com/containerd/ttrpc-rust/pull/226/files#diff-e74ddb472174f24fb4713f5a2fe2d33bbc5db28ee2a5c7dad1ea9025b897e8a5R110

There already are monitor_fd to notify exit, so accept without timeout is safe.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.74%. Comparing base (c3889f6) to head (dc6b697). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/sync/sys/unix/net.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #249 +/- ## ======================================= Coverage 24.74% 24.74% ======================================= Files 16 16 Lines 2675 2675 ======================================= Hits 662 662 Misses 2013 2013 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.