search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

wip-check action would set commit status to failure and the commit will be marked as failure forever #52

Closed Tim-Zhang closed 4 years ago

Tim-Zhang commented 4 years ago

Due to the GitHub mechanism, it is unwise to use GitHub actions to do work-in-process check

Please see below picture: image

Github actions will set the commit status to failure when WIP is detected and this failed status will always be accompanied by this commit, mark the commit as failure for ever.

After my investigation, I found that GitHub action is indeed not suitable for this work. I think we can replace the Action wip-check with a GitHub App: https://github.com/apps/wip

This is the same issue with kata-containers/kata-containers#525

Tim-Zhang commented 4 years ago

Close temporarily