search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
197 stars 47 forks source link

Lock the version of protobuf to 2.8.0 #7

Closed Tim-Zhang closed 4 years ago

Tim-Zhang commented 4 years ago

Got: cargo run --example server unix:///tmp/1 error[E0425]: cannot find value VERSION_2_8_0 in crate protobuf

This commit fixes this error.

Signed-off-by: Tim Zhang tim@hyper.sh

teawater commented 4 years ago

@Tim-Zhang Please add reason why ttrpc need lock on this version in the commit log.

teawater commented 4 years ago

@Tim-Zhang For example, some build fail log.

teawater commented 4 years ago

https://github.com/alipay/ttrpc-rust/blob/master/examples/protocols/Cargo.toml#L9 And I think this is the core reason that why it got error. I think we should update the both version and lock them together.

Tim-Zhang commented 4 years ago

@teawater I have updated the pull-request follow your advice, please review again. thank you.

teawater commented 4 years ago

@Tim-Zhang When you think your version is OK, please let @lifupan help to test this commit. If the test pass, I am OK with this change. @lifupan could you help me merge this PR when it pass the test with your project?

teawater commented 4 years ago

@Tim-Zhang When you think your version is OK, please let @lifupan help to test this commit. If the test pass, I am OK with this change. @lifupan could you help me merge this PR when it pass the test with your project?