search

containerd / ttrpc

GRPC for low-memory environments
Apache License 2.0
536 stars 78 forks source link

Add Makefile and update protobuf #106

Closed dmcgowan closed 2 years ago

dmcgowan commented 2 years ago

Updates protobuf version to v3.11.4 to match with containerd. Adds a Makefile for the workflow and updates ci to use Makefile.

codecov-commenter commented 2 years ago

Codecov Report

Merging #106 (f8e8cc4) into main (aa5c947) will decrease coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
- Coverage   63.87%   63.67%   -0.20%     
==========================================
  Files          11       11              
  Lines        1049     1049              
==========================================
- Hits          670      668       -2     
- Misses        334      336       +2     
  Partials       45       45
Impacted Files Coverage Δ
src/github.com/containerd/ttrpc/server.go 76.01% <0.00%> (-0.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa5c947...f8e8cc4. Read the comment docs.

dmcgowan commented 2 years ago

Marked this as ready for review. There was originally a failure on Windows showing a closed that was not caught. It stopped showing up but I added more logging so we can see the type of error to check in the future.