search

containerd / ttrpc

GRPC for low-memory environments
Apache License 2.0
536 stars 78 forks source link

Update GitHub actions CI workflow #124

Closed austinvazquez closed 1 year ago

austinvazquez commented 1 year ago

Update GitHub actions runner OS from Ubuntu 18.04 to Ubuntu 22.04. Update Go compiler from Go 1.17 to Go 1.20. Update actions/setup-go from v2 to v3. Update golangci-lint to v1.51.x for Go 1.20 support. Remove deprecated -i flag from make coverage target.

Related issue: https://github.com/containerd/project/issues/95

Signed-off-by: Austin Vazquez macedonv@amazon.com

estesp commented 1 year ago

This seems to be consistently failing even after 2 re-runs:

--- FAIL: TestServerShutdown (0.00s)
    server_test.go:275: expected connections to be empty: map[0xc000097d10:{}]

only on Windows platform. Not sure what's up there

austinvazquez commented 1 year ago

This seems to be consistently failing even after 2 re-runs:

--- FAIL: TestServerShutdown (0.00s)
    server_test.go:275: expected connections to be empty: map[0xc000097d10:{}]

only on Windows platform. Not sure what's up there

I'm looking into this more. It looks like a flaky test on Windows as it is now failing in mainline.

austinvazquez commented 1 year ago

I split troubleshooting of flaky tests into #129 and #131

estesp commented 1 year ago

Rebase now and this should be mergable

austinvazquez commented 1 year ago

Rebase now and this should be mergable

Rebased. Will continue to troubleshoot Windows CI flakiness further but this should in a good enough state to keep the lights on for CI / unblock the telemetry work by @swagatbora90 .