search

containerd / ttrpc

GRPC for low-memory environments
Apache License 2.0
536 stars 78 forks source link

TestServerShutdown is flaky on Windows #129

Closed austinvazquez closed 1 year ago

austinvazquez commented 1 year ago

TestServerShutdown has been intermittently failing in the pipeline due to leftover connections not being closed.

Current shutdown logic will issue close on idle connections and pause for 200 ms before reevaluating. Shutdown should be waiting for each connection to be closed but that does not appear to be the case.

austinvazquez commented 1 year ago

Clarification: during troubleshooting, I found the server was still accepting connections without checking shutdown status. My solution in #130 is to simplify the shutdown logic and add a check to accept connection for shutdown status.