Fix server shutdown logic

containerd / ttrpc

GRPC for low-memory environments

Apache License 2.0

559 stars 80 forks source link

Fix server shutdown logic #130

Closed austinvazquez closed 1 year ago

austinvazquez commented 1 year ago

Fixes #129

Simplify close idle connections logic in server shutdown to be more intuitive. Modify add connection logic to check if server has been shutdown before adding any new connections. Modify test to make all calls before server shutdown.

Signed-off-by: Austin Vazquez macedonv@amazon.com

austinvazquez commented 1 year ago

[x] CI #269 https://github.com/containerd/ttrpc/actions/runs/4267337122
[x] CI #271 https://github.com/containerd/ttrpc/actions/runs/4267396516
[x] CI #274 https://github.com/containerd/ttrpc/actions/runs/4267430984 unknown failure in coverage stage. All unit tests passed.
[x] CI #275 https://github.com/containerd/ttrpc/actions/runs/4267488630 failed for #131 TestServerShutdown passed.
[x] CI #276 https://github.com/containerd/ttrpc/actions/runs/4267523549
[x] CI #278 https://github.com/containerd/ttrpc/actions/runs/4284558474
[x] CI #279 https://github.com/containerd/ttrpc/actions/runs/4284722035

kzys commented 1 year ago

@dmcgowan @cpuguy83 PTAL