search

containerd / ttrpc

GRPC for low-memory environments
Apache License 2.0
558 stars 80 forks source link

Copy codes and status pkg from grpc #54

Closed crosbymichael closed 5 years ago

crosbymichael commented 5 years ago

This copies the codes and status package from grpc as it is the only references to the grpc project from ttrpc. This will help ensure that API breaking changes in grpc do not affect ttrpc.

Signed-off-by: Michael Crosby crosbymichael@gmail.com

estesp commented 5 years ago

This definitely seems like a good thing to do, but our ltag header check is going to get upset about the fileheaders from the gRPC project (which I think should be left in).. hmm.

dmcgowan commented 5 years ago

We can add our copyright above, we just shouldn't remove the old one

estesp commented 5 years ago

need a revendor to drop dependencies

fuweid commented 5 years ago

the CI issue will be fixed by #55

crosbymichael commented 5 years ago

What command do I run in my PR to update the go.sum/mod files to make CI happy?

fuweid commented 5 years ago

Hi @crosbymichael , you just need to run go mod tidy which will add digest for module content. CI will happy with that.

crosbymichael commented 5 years ago

All green and happy now. Thanks for the tip with gomod @fuweid