search

containerd / ttrpc

GRPC for low-memory environments
Apache License 2.0
558 stars 80 forks source link

Use google.golang.org/grpc/encoding to decode protobuf #90

Closed kzys closed 3 years ago

kzys commented 3 years ago

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

codecov-commenter commented 3 years ago

Codecov Report

Merging #90 (fd85b85) into main (360e86c) will increase coverage by 2.48%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   70.75%   73.23%   +2.48%     
==========================================
  Files          11       11              
  Lines         612      710      +98     
==========================================
+ Hits          433      520      +87     
- Misses        142      153      +11     
  Partials       37       37
Impacted Files Coverage Δ
client.go 80.66% <ø> (-0.87%) :arrow_down:
codec.go 71.42% <100.00%> (+11.42%) :arrow_up:
services.go 47.36% <100.00%> (+5.57%) :arrow_up:
handshake.go 100.00% <0.00%> (ø)
interceptor.go 100.00% <0.00%> (ø)
metadata.go 93.02% <0.00%> (+2.39%) :arrow_up:
server.go 76.92% <0.00%> (+2.43%) :arrow_up:
channel.go 84.31% <0.00%> (+2.49%) :arrow_up:
config.go 33.33% <0.00%> (+3.33%) :arrow_up:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 360e86c...fd85b85. Read the comment docs.

kzys commented 3 years ago

It would be better to do #91 instead of this one, to migrate off from gogo/protobuf completely.