search

containernetworking / cni.dev

CNI website
https://cni.dev
Apache License 2.0
48 stars 55 forks source link

Add detailed info about vlan capabilities on bridge #134

Open mlguerrero12 opened 1 year ago

mlguerrero12 commented 1 year ago

It was not clear how the vlan related parameters worked. This aims to fill this gap.

mlguerrero12 commented 9 months ago

Thank you for making things clearer on how to support VLAN/s.

It is indeed challenging to explain this well, especially when the linux bridge has such a complex configuration. I think my main point in my comments is that the explanation should be done from the abstraction provided by the plugin settings, not from the bridge perspective.

In classic switches, the notion of a trunk and a native VLAN is pretty clear. If it is possible to explain it in that manner here as well, it will help a lot.

Thanks for the comments @EdDev.

I understand your point and agree with them. However, I decided to put bridge details because I've seen issues created asking for those. Also, there have been attempts to modify the way we do trunking here and we had to explain why it can't be. Here for example https://github.com/containernetworking/plugins/issues/939.

For the above, I prefer to leave these details until we see how we can simplify the vlan support for the bridge.